Support timeout in Python SDK #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolyatmax
approved these changes
Feb 14, 2025
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
|
|
||
| def exec(self, code: str) -> ReplExecResult: | ||
| def exec( | ||
| self, code: str, timeout_seconds: int = DEFAULT_INSTRUCTION_TIMEOUT_SECONDS |
Contributor
There was a problem hiding this comment.
Consider validating that timeout_seconds is a positive integer.
feliciachang
pushed a commit
that referenced
this pull request
Feb 14, 2025
* Add start command (#102) * Add start command * newline * Improve header logging (#101) * Improve header logging * Accept ellipsis comments * 0.1.25 (#103) * Add timeout option to CLI repl (#104) * Support timeout in Python SDK (#106) * add timeout option to js sdk (#107) * Paul's changes on MCP install --------- Co-authored-by: Jake Lazaroff <1223007+jakelazaroff@users.noreply.github.com> Co-authored-by: Taylor Baldwin <taylorbaldwin@gmail.com>
paulgb
added a commit
that referenced
this pull request
Feb 14, 2025
* Add start command (#102) * Add start command * newline * Improve header logging (#101) * Improve header logging * Accept ellipsis comments * 0.1.25 (#103) * Add timeout option to CLI repl (#104) * Support timeout in Python SDK (#106) * add timeout option to js sdk (#107) * Paul's changes on MCP install --------- Co-authored-by: Jake Lazaroff <1223007+jakelazaroff@users.noreply.github.com> Co-authored-by: Taylor Baldwin <taylorbaldwin@gmail.com>
feliciachang
added a commit
that referenced
this pull request
Feb 14, 2025
* init * create config path * uninstall types * wip * wip * wip * wip * addressing comments * addressing comments * Paul's changes on MCP install (#108) * Add start command (#102) * Add start command * newline * Improve header logging (#101) * Improve header logging * Accept ellipsis comments * 0.1.25 (#103) * Add timeout option to CLI repl (#104) * Support timeout in Python SDK (#106) * add timeout option to js sdk (#107) * Paul's changes on MCP install --------- Co-authored-by: Jake Lazaroff <1223007+jakelazaroff@users.noreply.github.com> Co-authored-by: Taylor Baldwin <taylorbaldwin@gmail.com> * fix package-lock.json * probably fix build issues --------- Co-authored-by: Paul Butler <paul@driftingin.space> Co-authored-by: Jake Lazaroff <1223007+jakelazaroff@users.noreply.github.com> Co-authored-by: Taylor Baldwin <taylorbaldwin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports an additional, optional,
timeout_secondsparameter toexec. This supplies a timeout (in seconds) that overrides the default of 15s.