Skip to content

Fix delayed daily updates without duplicate refreshes - #19

Merged
jammyfu merged 2 commits into
mainfrom
fix/delayed-daily-update
Nov 7, 2026
Merged

jammyfu merged 2 commits into
mainfrom
fix/delayed-daily-update

Conversation

@jammyfu

@jammyfu jammyfu commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Problem

Scheduled runs 42235915488 and 42243101773 started about seven hours late. The hour-only guard returned skip, so both runs were green without fetching or publishing data.

Change

  • Compare the committed data's generated_at with the current Los Angeles calendar date.
  • Allow delayed runs to catch up; skip the second trigger after a same-day refresh is committed.
  • Preserve both existing UTC cron entries, workflow concurrency, fresh main checkout, manual dispatch, and local fallback behavior.
  • Fail visibly on invalid or future scheduling state instead of treating every nonzero exit as an intentional skip.
  • Add CLI and real workflow-shell regression tests, operator documentation, and governance records.
  • Correct both English and Simplified Chinese public Pages copy, search/social descriptions and FAQ structured metadata to say daily.

No ranking calculations, generated files, translations, or secrets are changed in this PR.

Verification

  • python3 tools/verify.py: 231 tests plus render/translation checks passed.
  • python3 tools/verify.py --daily: passed.
  • python3 tools/next_plan.py --check and git diff --check: passed.
  • Late-run regression failed before the fix and passed after it.
  • Independent review found no actionable issues; all 21 schedule tests independently passed.
  • Full-year simulation: both triggers delayed seven hours still produce one refresh per LA day on all 365 days of 2026.

Production recovery

Existing manual workflow 42373937914 succeeded separately and published 2656f404, generated at 2026-11-07T12:46:19Z. All 70 projects fetched, zero missing, seven newcomer categories succeeded, and Pages deployed the same commit successfully.

Owner authorized merging this PR and correcting the public Pages descriptions. Final copy changes passed independent review, JSON-LD/content checks and full verification. Merge only the exact verified head after CI succeeds; then verify main CI and Pages deployment. The next unattended schedule remains a follow-up observation.

@jammyfu
jammyfu marked this pull request as ready for review November 7, 2026 13:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T13:07:47.239145Z a68e8fb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jammyfu
jammyfu merged commit ed3ee08 into main Nov 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant