Skip to content

Split out HTTP(S) (ureq) and image default-formats into features#165

Merged
jamjamjon merged 3 commits intojamjamjon:mainfrom
glasgow-haskell-omelette:main
Dec 11, 2025
Merged

Split out HTTP(S) (ureq) and image default-formats into features#165
jamjamjon merged 3 commits intojamjamjon:mainfrom
glasgow-haskell-omelette:main

Conversation

@glasgow-haskell-omelette
Copy link
Copy Markdown
Contributor

@glasgow-haskell-omelette glasgow-haskell-omelette commented Nov 30, 2025

Vel is not sure whether this is ready for merging (it probably isn't), so is opening a draft PR for now.

LLM disclosure: it has inline LLM completions enabled in its editor, but isn't sure if it has even used them here.

@glasgow-haskell-omelette
Copy link
Copy Markdown
Contributor Author

it seems fine. probably

@glasgow-haskell-omelette glasgow-haskell-omelette marked this pull request as ready for review December 1, 2025 06:39
@glasgow-haskell-omelette
Copy link
Copy Markdown
Contributor Author

going to rebase later

@glasgow-haskell-omelette
Copy link
Copy Markdown
Contributor Author

okay so, apparently the SAM3 changes fixed the "issue" with image and ureq to some degree by reducing their features, although not fully. what should Vel do about this PR?

cc @jamjamjon ig (sorry if this is annoying)

@jamjamjon
Copy link
Copy Markdown
Owner

@glasgow-haskell-omelette Thanks for your contribution! I’ll take some time to review the changes and get back to you soon.

@jamjamjon
Copy link
Copy Markdown
Owner

@glasgow-haskell-omelette I made a few changes:

  • Renamed http to github
  • Moved the http crate into the github feature as well
  • Pin zune-jpeg to 0.5.5 due to a macOS-specific bug in 0.5.6

@jamjamjon jamjamjon merged commit 918a70a into jamjamjon:main Dec 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants