Fix Haversack.search only returning a single item #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobHearst
requested review from
AlexSlukin,
johnlehouerou,
mirosliacky and
taher-mosbah
team-adder
bot
requested review from
BartO-jamf,
BrandonRoehl,
JakubStanglicaWND,
JanSkrabal,
KapnKerk,
Saczuu,
alexrepty,
c7bercat,
camdenwebster,
jakubKozakW,
jmarchesini,
lukyratica,
macshome,
mcanigova,
mjKosmic,
mlink,
mmuzikar,
open-abbott,
palisladek,
pmoprhy,
radimcervinka,
sameh0 and
teeweizhong10
mjKosmic
approved these changes
Jan 2, 2026
BartO-jamf
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced in the effort to improve
HaversackEphemeralStrategyergonomics. As of writing, those changes haven't been tagged and released so this isn't urgent.I was unable to write a unit test for this because searches for both single and multiple items include the
kSecMatchLimit(source). This means that the dictionary keys generated by the ephemeral strategy look identical (classkeyslablexamm_Limitm_Lir_Datavsclasskeyslablexamm_Limitm_Lir_Data). I could, of course, change the key generation strategy but that would break unit tests for consumers of this library.Since I couldn't write tests, I did a manual review of calls to
makeSearchQueryand the other query builder functions to double check there were no other similar errors.