rock paper scissors - cleaned up code #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2018 08:03
yousifS
reviewed
Aug 1, 2018
| @@ -0,0 +1,28 @@ | |||
| { | |||
There was a problem hiding this comment.
TicTacToe should not be in this branch.
yousifS
reviewed
Aug 1, 2018
| { | ||
| // Your code here | ||
| return hand1 + ' ' + hand2; | ||
| string player1Hand = ""; |
There was a problem hiding this comment.
I like that you have multiple methods, but some comments before each method explaining what the method does would have been nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.