Skip to content

Fixed 1 bug (due to archive.org update) and added 3 functions (one from the to-do section)#8

Open
othellodesutter wants to merge 7 commits intojamessucla:masterfrom
othellodesutter:master
Open

Fixed 1 bug (due to archive.org update) and added 3 functions (one from the to-do section)#8
othellodesutter wants to merge 7 commits intojamessucla:masterfrom
othellodesutter:master

Conversation

@jamessucla
Copy link
Owner

jamessucla commented Jul 31, 2023

I just tried this out, and it's great that you fixed the InvalidURL issue, but it will crash trying to import the config module if one doesn't exist. I assume that was intended to be optional.

@jamessucla
Copy link
Owner

jamessucla commented Jul 31, 2023

And I'm getting this error on the stitcher script with macOS 13.4.1:

Enter the directory of the images: chiltonstoyotace0000unse_b0s4
Enter the id of the book: chiltonstoyotace0000unse_b0s4
Traceback (most recent call last):
  File "~/git/archiveripper/stitcher.py", line 32, in <module>
  File "~/git/archiveripper/stitcher.py", line 12, in stitch
  File "~/Library/Python/3.9/lib/python/site-packages/PIL/Image.py", line 3131, in open
OSError: [Errno 24] Too many open files: 'chiltonstoyotace0000unse_b0s4/253.jpg'

There is a pretty simple workaround, which is passing in a higher value to ulimit -n, but it might be a good idea to give a user-friendly message when this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants