Conversation
jakex7
approved these changes
Mar 3, 2025
Owner
jakex7
left a comment
jakex7
left a comment
There was a problem hiding this comment.
Thanks! I've pushed an option to specify defaultLanguage in case Apple utilizes sourceLanguage, though it's not necessary.
|
Hello, @jakex7! Did you plan to release the hotfix? |
|
Hi @jakex7 could we make a release for this fix? It is nice to get rid of the warning from AppStore. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current expo plugin is causing iOS warnings when submitted for apple app store review as mentioned in the issue here.
The problem lies in the generation of
Localizable.stringsfile inbase.lprojfolder with the current plugin and as mentioned in this stack overflow, the base internationalization directory should not have.stringsfiles thus this PR removes the code that generates the.stringsfile inbase.lprojNOTE: Tested this on own project with patch and apple is no longer giving the warning