Centralize FileAccess audit logging in DFS with structured format#169
Draft
Copilot wants to merge 8 commits intocandidate-10.2.xfrom
Draft
Centralize FileAccess audit logging in DFS with structured format#169Copilot wants to merge 8 commits intocandidate-10.2.xfrom
Copilot wants to merge 8 commits intocandidate-10.2.xfrom
Conversation
Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com>
Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com>
Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com>
Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com>
Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com>
Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com>
Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor FileAccess audit logging into DFS implementation
Centralize FileAccess audit logging in DFS with structured format
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileAccess audit logging was scattered across 6+ components with inconsistent CSV-style formats and missing DFS-side metadata (file sizes, clusters). This refactor moves all audit emission into DFS, standardizes to JSON Lines format, and enriches records with compressed/uncompressed sizes.
Changes
Audit Context Infrastructure
IDFSAuditContextinterface with required fields (user,peer,component,instance) and optional fields (wuid,graph,jobId)setDFSAuditContext()/queryDFSAuditContext()DFSAuditScopeRAII helper for scoped context managementemitDFSAuditLog()exported for components that bypass DFS operationsDFS Audit Emission
lookup(): emits READ audit only for content access (skipsAccessMode::readMeta)removeEntry(): emits DELETED auditrename()/renamePhysical(): emit RENAMED auditCaller Refactoring
IEspContext, useDFSAuditScopeAuditMessage()to use JSON formatExample
Format Migration
Before:
After:
{"type":"FileAccess","action":"READ","component":"Thor","instance":"nodegroup","user":"user","peer":"","logicalName":"file.dat","wuid":"W20240101-120000","graph":"graph1","compressedSize":512,"uncompressedSize":1024,"cluster":"cluster1","numClusters":2}Notes
readMeta) correctly skip auditing💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.