duplicate persistent field names in hierarchy#945
Merged
gavinking merged 6 commits intojakartaee:mainfrom Feb 24, 2026
Merged
Conversation
gavinking
force-pushed
the
dupe-fields
branch
from
a140ade to
c280066
Compare
gavinking
force-pushed
the
dupe-fields
branch
from
c280066 to
f25e154
Compare
Member
Author
|
@sebersole @mbellade does look right? |
sebersole
reviewed
Feb 5, 2026
Contributor
sebersole
left a comment
sebersole
left a comment
There was a problem hiding this comment.
I think the semantics you define are logical. I do think the section could benefit from some sample code to help illustrate what is and is not supported.
Member
Author
|
OK, will do. |
njr-11
approved these changes
Feb 5, 2026
Member
Author
|
@sebersole I have added some examples. Is this what you were looking for? |
beikov
reviewed
Feb 12, 2026
gavinking
force-pushed
the
dupe-fields
branch
from
5376873 to
46e9d15
Compare
…same column as long as they belong to distinct branches of hierarchy
Member
Author
|
I have generalized and simplified the restriction on duplicate column mappings. |
Member
Author
|
Alright, I guess this clarification has had enough time to stew now, and three different people have reviewed. Time to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update spec to address cases raised in #599.