Remove declaration of ResultSetMapping as sealed#886
Open
sebersole wants to merge 1 commit intojakartaee:mainfrom
Open
Remove declaration of ResultSetMapping as sealed#886sebersole wants to merge 1 commit intojakartaee:mainfrom
sebersole wants to merge 1 commit intojakartaee:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hibernate, and I am assuming other providers, have historical ways to define more rich ResultSet mappings.
Because ResultSetMapping was introduced as sealed and all of its impls as records, it is impossible to model those richer models using this API; which is a shame imo. Here is a PR to remove the seal and allow such usage.
A further step would be to make the impls NOT records. This would allow even better implementation of this idea by implementors. I held off on that for the time being until we had consensus on this idea in general.
#887