feat: add S3 auth support (behind a new feature flag)#172
Open
mat813 wants to merge 1 commit intojaemk:masterfrom
Open
feat: add S3 auth support (behind a new feature flag)#172mat813 wants to merge 1 commit intojaemk:masterfrom
mat813 wants to merge 1 commit intojaemk:masterfrom
Conversation
Collaborator
|
Have you tested this? |
GideonBear
approved these changes
Apr 4, 2026
Collaborator
GideonBear
left a comment
GideonBear
left a comment
There was a problem hiding this comment.
Few nits, assuming you've tested everything, and have done your research on how to implement AWS sign v4 :)
| ureq = { version = "3.0.6", optional = true, default-features = false, features = ["gzip", "json", "socks-proxy", "charset"]} | ||
|
|
||
| hmac = { version = "0.12.1", optional = true } | ||
| base64 = { version = "0.22.1", optional = true } |
|
|
||
| /// RFC 3986 percent-encoding, as required by AWS SigV4. | ||
| /// `encode_slash = true` for query param values, `false` for URI path segments. | ||
| fn uri_encode(input: &str, encode_slash: bool) -> String { |
Collaborator
There was a problem hiding this comment.
Is there a crate for this?
| @@ -607,6 +814,9 @@ fn fetch_releases_from_s3( | |||
|
|
|||
| debug!("using api url: {:?}", api_url); | |||
Collaborator
There was a problem hiding this comment.
Should this be placed below?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88