Skip to content

feat(s3)!: support generic S3 endpoints#171

Merged
GideonBear merged 1 commit intojaemk:masterfrom
mat813:generic-s3
Apr 4, 2026
Merged

feat(s3)!: support generic S3 endpoints#171
GideonBear merged 1 commit intojaemk:masterfrom
mat813:generic-s3

Conversation

@mat813
Copy link
Copy Markdown
Contributor

@mat813 mat813 commented Mar 26, 2026

This allows using a non standard S3 endpoint.
Closes #115

@GideonBear
Copy link
Copy Markdown
Collaborator

Edited your description to link #115

@mat813 mat813 requested a review from GideonBear March 26, 2026 16:49
Copy link
Copy Markdown
Collaborator

@GideonBear GideonBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mat813
Copy link
Copy Markdown
Contributor Author

mat813 commented Mar 27, 2026

It seems the change to build(self) makes the doc tests fail, so I reverted that part, the only change is one clone on the EndPoint enum

@mat813
Copy link
Copy Markdown
Contributor Author

mat813 commented Mar 27, 2026

Added a bit of documentation

@mat813 mat813 force-pushed the generic-s3 branch 3 times, most recently from 0000343 to 0000343 Compare March 31, 2026 12:55
Copy link
Copy Markdown
Collaborator

@GideonBear GideonBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@GideonBear GideonBear changed the title Add generic S3 endpoints feat(s3)!: support generic S3 endpoints Apr 4, 2026
@GideonBear GideonBear merged commit 16f888a into jaemk:master Apr 4, 2026
2 checks passed
@mat813 mat813 deleted the generic-s3 branch April 4, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request/RFC: Abolish backends::s3::EndPoint or add Custom(function) element

2 participants