Skip to content

Debug evaluation-library#12

Open
Sichao25 wants to merge 42 commits intojacobmerson:evaluation-libraryfrom
Sichao25:evaluation-library
Open

Debug evaluation-library#12
Sichao25 wants to merge 42 commits intojacobmerson:evaluation-libraryfrom
Sichao25:evaluation-library

Conversation

@Sichao25
Copy link
Copy Markdown

@Sichao25 Sichao25 commented Apr 3, 2026

Debugged all compiler errors and ensured all tests pass for the current work-in-progress in the evaluation library. Set device memory as the default backend for most implementations.

@Sichao25
Copy link
Copy Markdown
Author

Sichao25 commented Apr 3, 2026

Would you mind taking a look at src/pcms/utility/arrays.h? I added some functions to copy between mdspan and view. Since using device memory should minimize the use cases, I've kept those functions with explicit memory space names for clarity. It might be possible to combine them into a single templated function, similar to kokkos copy. Let me know if there's a better approach or if existing methods already handle this.

Update:
It seems we can minimize, or nearly eliminate, the use of these helper functions.

@Sichao25
Copy link
Copy Markdown
Author

@jacobmerson I think this is ready for an initial review. If it looks good, I will reformat the code and open a PR directly to SCOREC/pcms. We can review the CI results there and determine what else should be included in the PR.

@Sichao25 Sichao25 force-pushed the evaluation-library branch from 62142e1 to 9987eb7 Compare April 27, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants