Debug evaluation-library#12
Open
Sichao25 wants to merge 42 commits intojacobmerson:evaluation-libraryfrom
Open
Debug evaluation-library#12Sichao25 wants to merge 42 commits intojacobmerson:evaluation-libraryfrom
Sichao25 wants to merge 42 commits intojacobmerson:evaluation-libraryfrom
Conversation
closes SCOREC#257
enable building without petsc
remove spdlog
need host/device fn, use kokkos array
default petsc to off
Remove unused variables
Create Dockerfile
Author
|
Would you mind taking a look at Update: |
Author
|
@jacobmerson I think this is ready for an initial review. If it looks good, I will reformat the code and open a PR directly to SCOREC/pcms. We can review the CI results there and determine what else should be included in the PR. |
Enable petsc shared build in ci
62142e1 to
9987eb7
Compare
jacobmerson
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugged all compiler errors and ensured all tests pass for the current work-in-progress in the evaluation library. Set device memory as the default backend for most implementations.