fix: allow browser:false commands to run without page after lazy-load#347
Merged
fix: allow browser:false commands to run without page after lazy-load#347
Conversation
The C2 fix in PR #337 added a null-page guard after lazy-loading TS modules, but it threw unconditionally — breaking all browser:false commands (bloomberg, apple-podcasts, google, yollomi, etc.) that use func() with a null page. Guard now checks updated.browser !== false. Also fixes apple-podcasts top E2E flake: when the command times out on CI, stderr is empty and the guard didn't catch it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execution.tsafter lazy-loading, breaking allbrowser: falsecommands (bloomberg, apple-podcasts, google, yollomi, weread, xiaoyuzhou) — 23 E2E failuresupdated.browser !== falseChanges
src/execution.ts: conditional browser check before throwingtests/e2e/public-commands.test.ts: timeout-aware guard for apple-podcastsTest plan
npm run typecheck— cleannpm test— 223 tests pass🤖 Generated with Claude Code