fix: allow browser:false commands to run without page after lazy-load#345
Closed
fix: allow browser:false commands to run without page after lazy-load#345
Conversation
- R1: Extract isRecord() type guard to shared src/utils.ts (8 files) - R2: Merge duplicate mapConcurrent() to shared utils (fetch.ts + download.ts) - R3: Extract saveBase64ToFile() helper (cdp.ts + page.ts) - R4: Merge _tabOpt() + _workspaceOpt() into _cmdOpts()/_wsOpt() (page.ts) - R5: Extract normalizeRows() + resolveColumns() in output.ts - R6: Remove dead register stub from generate.ts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When the apple-podcasts top command times out on CI, the child process is killed with empty stderr. The existing guard didn't catch this case, causing a flaky E2E failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jackwener
force-pushed
the
fix/ci-e2e-public-commands
branch
from
7bf5ba4 to
9e783d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execution.tsafter lazy-loading TS modules, but it threw unconditionally — breaking allbrowser: falsecommands (bloomberg, apple-podcasts, google, yollomi, weread, xiaoyuzhou) that callfunc()with a null pagepublic-commands.test.tson CIupdated.browser !== falsebefore throwingRoot cause
Line 102 in
execution.tswas:Should be:
Test plan
npm run typecheck— cleannpm test— 223 tests passbloomberg main,bloomberg feeds,yollomi models,apple-podcasts searchall return data correctlypageis null🤖 Generated with Claude Code