Skip to content

feat(linkedin): add timeline feed command#342

Merged
jackwener merged 2 commits intojackwener:mainfrom
piotryordanov:feat/linkedin-timeline
Mar 24, 2026
Merged

feat(linkedin): add timeline feed command#342
jackwener merged 2 commits intojackwener:mainfrom
piotryordanov:feat/linkedin-timeline

Conversation

@piotryordanov
Copy link
Contributor

Summary

  • add a new linkedin timeline browser adapter to read posts from the LinkedIn home feed
  • extract author profile URLs, best-effort post URLs, timestamps, and engagement counts from feed cards
  • document the new command in the LinkedIn adapter docs and adapter index

piotryordanov and others added 2 commits March 24, 2026 15:50
Add shape tests and utility function tests for the new timeline command.
Include linkedin in the vitest adapter project config.
@jackwener jackwener force-pushed the feat/linkedin-timeline branch from 6f69578 to 555d283 Compare March 24, 2026 07:53
Copy link
Owner

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Good work on this PR. The LinkedIn timeline adapter is well-structured with solid deduplication logic, login wall detection, and robust DOM parsing across multiple LinkedIn feed card layouts.

What I pushed

  1. Added test file (src/clis/linkedin/timeline.test.ts) — 10 tests covering:

    • Command shape registration (site, name, domain, strategy, browser flag)
    • Arg defaults (limit=20)
    • Column definitions
    • parseMetric utility (plain numbers, k/m suffixes, edge cases)
    • buildPostId (url-first fallback to composite key)
    • mergeTimelinePosts deduplication and filtering
  2. Updated vitest config to include src/clis/linkedin/**/*.test.ts in the adapter test project.

Validation

  • Typecheck: ✅ passes
  • All 242 tests pass (22 files, including the new timeline tests)
  • Rebased cleanly onto latest origin/main

Notes

  • normalizeWhitespace is duplicated from search.ts — could be extracted to a shared util in a future cleanup, but not blocking.
  • The __test__ export is a good pattern for exposing internals to tests.

LGTM — merging after CI is green.

@jackwener jackwener merged commit 8869d3b into jackwener:main Mar 24, 2026
@piotryordanov
Copy link
Contributor Author

Lol @jackwener i had manually removed that file before the push

What are you using to automate the PA merge? This is clearly vibe reviewed

@piotryordanov piotryordanov deleted the feat/linkedin-timeline branch March 24, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants