feat(linkedin): add timeline feed command#342
Merged
jackwener merged 2 commits intojackwener:mainfrom Mar 24, 2026
Merged
Conversation
Add shape tests and utility function tests for the new timeline command. Include linkedin in the vitest adapter project config.
6f69578 to
555d283
Compare
jackwener
approved these changes
Mar 24, 2026
Owner
jackwener
left a comment
There was a problem hiding this comment.
Review Summary
Good work on this PR. The LinkedIn timeline adapter is well-structured with solid deduplication logic, login wall detection, and robust DOM parsing across multiple LinkedIn feed card layouts.
What I pushed
-
Added test file (
src/clis/linkedin/timeline.test.ts) — 10 tests covering:- Command shape registration (site, name, domain, strategy, browser flag)
- Arg defaults (limit=20)
- Column definitions
parseMetricutility (plain numbers, k/m suffixes, edge cases)buildPostId(url-first fallback to composite key)mergeTimelinePostsdeduplication and filtering
-
Updated vitest config to include
src/clis/linkedin/**/*.test.tsin the adapter test project.
Validation
- Typecheck: ✅ passes
- All 242 tests pass (22 files, including the new timeline tests)
- Rebased cleanly onto latest
origin/main
Notes
normalizeWhitespaceis duplicated fromsearch.ts— could be extracted to a shared util in a future cleanup, but not blocking.- The
__test__export is a good pattern for exposing internals to tests.
LGTM — merging after CI is green.
Contributor
Author
|
Lol @jackwener i had manually removed that file before the push What are you using to automate the PA merge? This is clearly vibe reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linkedin timelinebrowser adapter to read posts from the LinkedIn home feed