fix: resolve 11 important bugs from deep code review#340
Merged
Conversation
- I1: Log pre-navigation failures in debug mode instead of silently swallowing
- I2: Validate env var timeout values, fallback on NaN/negative
- I4: Guard against indexOf returning -1 for unknown strategies in cascade
- I5: Fix shouldReplaceManifestEntry returning true for same-type entries
- I6: Prevent infinite loop in parseTsArgsBlock cursor advancement
- I7: Skip redundant Page.enable calls in CDP goto
- I8: Fix wait({time:0}) being treated as falsy
- I10: Warn when cookiesFile path doesn't exist before fallback
- I11: Sanitize tab/newline chars in cookie name/value for Netscape format
- I12: Use DEFAULT_DAEMON_PORT constant instead of hardcoded port in error
- I15: Log npm install failures in plugin lifecycle instead of swallowing
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
Reviewed and merged. I re-ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execution.ts)runtime.ts)indexOfreturning -1 for unknown strategies in cascade (cascade.ts)shouldReplaceManifestEntryreturning true for same-type entries — was causing unnecessary overwrites (build-manifest.ts)parseTsArgsBlockcursor advancement (build-manifest.ts)Page.enableCDP calls on repeatedgoto()(cdp.ts)wait({time:0})being treated as falsy due toif (options.time)check (page.ts)cookiesFilepath doesn't exist before falling back to browser cookies (download/index.ts)download/index.ts)DEFAULT_DAEMON_PORTconstant instead of hardcoded port in error message (mcp.ts)plugin.ts)Test plan
tsc --noEmit)npm test)🤖 Generated with Claude Code