fix: harden security-sensitive execution paths#335
Merged
Conversation
jackwener
changed the title
1. cli.ts: Remove auto-discover of arbitrary system binaries via denylist. Unknown commands now require explicit registration via `opencli register`. The previous denylist approach was trivially bypassable (bash, curl, etc.). 2. template.ts: Protect evalJsExpr against prototype chain escape. Block expressions containing constructor/prototype/__proto__/process/etc. Deep-copy context objects to sever prototype chains before passing to new Function(). 3. external.ts: Expand shell operator detection in parseCommand to cover $(), $, #, \n, \r — preventing command substitution and comment injection. 4. fetch.ts: Use JSON.stringify for HTTP method in browser evaluate() instead of raw string interpolation, preventing JS injection via crafted method values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jackwener
force-pushed
the
fix/security-review-2026-03-24
branch
from
41f7431 to
a0c8a45
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencli registercli-manifest.jsonexists but is invalidnode:vmsandboxValidation