fix(xiaohongshu): attach real topics via inline "#" dropdown#1779
Open
E2ern1ty wants to merge 1 commit into
Open
fix(xiaohongshu): attach real topics via inline "#" dropdown#1779E2ern1ty wants to merge 1 commit into
E2ern1ty wants to merge 1 commit into
Conversation
The publish `--topics` flow relied on a standalone "添加话题" button plus a dedicated topic search `<input>` that the current creator-center editor no longer exposes. As a result each topic only inserted a bare `#` into the body with no linked topic entity, leaving notes ending in stray `####...`. Drive the editor's native inline flow instead: focus the body editor, type `#<topic>` to trigger the suggestion dropdown, then select the suggestion that best matches the topic (falling back to the first item, then to Enter). Topic failures stay non-fatal so the note still publishes. Also hoist the body-editor selectors into a shared `BODY_SELECTORS` constant reused by both the content fill and topic steps. Adds a unit test covering the inline dropdown selection path.
Contributor
Author
|
@jackwener Hi, could you help take a look at this PR when you have a moment? It fixes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The publish
--topicsflow relied on a standalone "添加话题" button plus a dedicated topic search<input>that the current creator-center editor no longer exposes. As a result each topic only inserted a bare#into the body with no linked topic entity, leaving notes ending in stray####....Drive the editor's native inline flow instead: focus the body editor, type
#<topic>to trigger the suggestion dropdown, then select the suggestion that best matches the topic (falling back to the first item, then to Enter). Topic failures stay non-fatal so the note still publishes.Also hoist the body-editor selectors into a shared
BODY_SELECTORSconstant reused by both the content fill and topic steps.Adds a unit test covering the inline dropdown selection path.
Related issue: N/A
Type of Change
Checklist
Documentation (if adding/modifying an adapter)
docs/adapters/(if new adapter)docs/adapters/index.mdtable (if new adapter)docs/.vitepress/config.mts(if new adapter)README.md/README.zh-CN.mdwhen command discoverability changedCliErrorsubclasses instead of rawErrorScreenshots / Output
Before: notes published with
--topics A,B,Cended in stray#######with zero linked topics.After: the same command attaches real topic entities; the note body ends cleanly with the selected topics.
Test: