Skip to content

fix(twitter): drop 'unknown' silent sentinel in search/notifications/following row fields #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Benjamin-eecs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(twitter): drop 'unknown' silent sentinel in search/notifications/following row fields #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clis/twitter/following.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ function extractUser(result) {
const core = result.core || {};
const legacy = result.legacy || {};
return {
screen_name: core.screen_name || legacy.screen_name || 'unknown',
name: core.name || legacy.name || 'unknown',
screen_name: core.screen_name || legacy.screen_name || '',
name: core.name || legacy.name || '',
Comment on lines +94 to +95
bio: legacy.description || result.profile_bio?.description || '',
followers: legacy.followers_count || legacy.normal_followers_count || 0,
};
Expand Down
13 changes: 13 additions & 0 deletions clis/twitter/following.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,19 @@ describe('twitter following helpers', () => {
expect(user?.screen_name).toBe('bob');
});

it('surfaces empty screen_name and name when upstream omits both', () => {
const user = __test__.extractUser({
__typename: 'User',
legacy: { description: 'no names', followers_count: 7 },
});
expect(user).toMatchObject({
screen_name: '',
name: '',
bio: 'no names',
followers: 7,
});
});

it('parses following timeline with users and cursor', () => {
const payload = {
data: {
Expand Down
8 changes: 4 additions & 4 deletions clis/twitter/notifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,14 @@ cli({
return;
let item = itemContent?.notification_results?.result || itemContent?.tweet_results?.result || itemContent;
let actionText = 'Notification';
let author = 'unknown';
let author = '';
let text = '';
let urlStr = '';
if (item.__typename === 'TimelineNotification') {
text = item.rich_message?.text || item.message?.text || '';
const fromUser = item.template?.from_users?.[0]?.user_results?.result;
// Twitter moved screen_name from legacy to core
author = fromUser?.core?.screen_name || fromUser?.legacy?.screen_name || 'unknown';
author = fromUser?.core?.screen_name || fromUser?.legacy?.screen_name || '';
urlStr = item.notification_url?.url || '';
actionText = item.notification_icon || 'Activity';
const targetTweet = item.template?.target_objects?.[0]?.tweet_results?.result;
Expand All @@ -94,14 +94,14 @@ cli({
else if (item.__typename === 'TweetNotification') {
const tweet = item.tweet_result?.result;
const tweetUser = tweet?.core?.user_results?.result;
author = tweetUser?.core?.screen_name || tweetUser?.legacy?.screen_name || 'unknown';
author = tweetUser?.core?.screen_name || tweetUser?.legacy?.screen_name || '';
text = tweet?.note_tweet?.note_tweet_results?.result?.text || tweet?.legacy?.full_text || item.message?.text || '';
actionText = 'Mention/Reply';
urlStr = `https://x.com/i/status/${tweet?.rest_id}`;
}
else if (item.__typename === 'Tweet') {
const tweetUser = item.core?.user_results?.result;
author = tweetUser?.core?.screen_name || tweetUser?.legacy?.screen_name || 'unknown';
author = tweetUser?.core?.screen_name || tweetUser?.legacy?.screen_name || '';
text = item.note_tweet?.note_tweet_results?.result?.text || item.legacy?.full_text || '';
actionText = 'Mention';
urlStr = `https://x.com/i/status/${item.rest_id}`;
Expand Down
2 changes: 1 addition & 1 deletion clis/twitter/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ function tweetToRow(result, seen) {
const bio = tweetUser?.legacy?.description || '';
return {
id: tweet.rest_id,
author: tweetUser?.core?.screen_name || tweetUser?.legacy?.screen_name || 'unknown',
author: tweetUser?.core?.screen_name || tweetUser?.legacy?.screen_name || '',
bio,
text: tweet.note_tweet?.note_tweet_results?.result?.text || tweet.legacy?.full_text || '',
created_at: tweet.legacy?.created_at || '',
Expand Down
35 changes: 35 additions & 0 deletions clis/twitter/search.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,40 @@ describe('twitter search command', () => {
expect(result.map((row) => row.id)).toEqual(['1', '2', '3', '4', '5', '6', '7']);
expect(page.evaluate).toHaveBeenCalledTimes(8);
});

it('surfaces empty author when the tweet has no user screen_name', () => {
const payload = {
data: {
search_by_raw_query: {
search_timeline: {
timeline: {
instructions: [{
type: 'TimelineAddEntries',
entries: [{
entryId: 'tweet-2',
content: {
itemContent: {
tweet_results: {
result: {
rest_id: '2',
legacy: { full_text: 'no author here', favorite_count: 0, created_at: '' },
core: { user_results: { result: {} } },
},
},
},
},
}],
}],
},
},
},
},
};
const { rows } = parseSearchTimeline(payload, new Set());
expect(rows).toHaveLength(1);
expect(rows[0].author).toBe('');
expect(rows[0].id).toBe('2');
});
});

describe('twitter search filter helpers', () => {
Expand Down Expand Up @@ -346,4 +380,5 @@ describe('twitter search end-to-end with new filters', () => {
const searchFetch = evaluate.mock.calls[1][0];
expect(searchFetch).toContain('\\"rawQuery\\":\\"from:alice\\"');
});

});
Loading