Allow expires at in generates_token_for to be a proc#3
Open
jackozi wants to merge 1 commit into
Open
Conversation
90481ca to
9b287f8
Compare
9b287f8 to
128f7c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The expires_in option in generates_token_for currently only accepts static duration values. Giving us no way to determine the expiration dynamically at runtime e.g., based on a per-tenant timeout.
Detail
TokenDefinition now has a resolved_expires_in method that evaluates expires_in if it's a proc, and returns as-is otherwise. The memoization on full_purpose has been removed so that procs are resolved on each call. Both generate_token and full_purpose now use resolved_expires_in. This allows usage like:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]