Handle multiple variables in define-let-to-multi-define#628
Closed
Handle multiple variables in define-let-to-multi-define#628
Conversation
Co-authored-by: jackfirth <8175575+jackfirth@users.noreply.github.com>
Co-authored-by: jackfirth <8175575+jackfirth@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Handle multiple variables in define-let-to-multi-define
Handle multiple variables in define-let-to-multi-define
Oct 24, 2025
Owner
|
Closing this in favor of fixing #641 first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the
define-let-to-double-definerefactoring rule to handle multiple bindings inletexpressions and renames it todefine-let-to-multi-defineto better reflect its new capability.Problem
Previously, the rule could only refactor
letexpressions with a single binding:would become:
However, it couldn't handle multiple bindings like this:
This is a valuable refactoring pattern that appears in real-world Racket code, such as in DrRacket.
Solution
The rule now accepts multiple bindings and generates the corresponding multiple
definestatements:Safety checks ensure the refactoring only applies when:
Changes
[nested-id:id nested-expr:expr] ...+instead of single bindingdefine-let-to-double-definetodefine-let-to-multi-defineAll existing tests pass, confirming backward compatibility with single-binding cases.
Fixes #623
Original prompt
Fixes #627
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.