Skip advisory lock when already at target version#142
Open
vadim2404 wants to merge 1 commit intojackc:masterfrom
Open
Skip advisory lock when already at target version#142vadim2404 wants to merge 1 commit intojackc:masterfrom
vadim2404 wants to merge 1 commit intojackc:masterfrom
Conversation
Adds a fast path to MigrateTo that returns early when the database is already at the target version, avoiding contention on the migrations advisory lock for schema-stable deploys (a common case in CI/CD where every deploy runs the migrator regardless of whether new migrations were added). Conservative by design: out-of-range versions and any GetCurrentVersion error fall through to the locked path, so error semantics are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fast path to MigrateTo that returns early when the database is already at the target version, avoiding contention on the migrations advisory lock for schema-stable deploys (a common case in CI/CD where every deploy runs the migrator regardless of whether new migrations were added).
Conservative by design: out-of-range versions and any GetCurrentVersion error fall through to the locked path, so error semantics are unchanged.