Apply automatic percent formatting#65
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fSizeTextControl(NULL), | ||
| fTextModificationRunner(NULL), | ||
| fWhat(message->what) | ||
| fWhat(message->what), |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule
| #include <FilePanel.h> | ||
| #include <LayoutBuilder.h> | ||
| #include <MessageRunner.h> | ||
| #include <NumberFormat.h> |
Check warning
Code scanning / Cppcheck (reported by Codacy)
Include file: <NumberFormat.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.
| uint32 flags = B_NAVIGABLE | B_WILL_DRAW | ||
| | B_FRAME_EVENTS); | ||
| bool isPercent = false, thumb_style thumbType = B_BLOCK_THUMB, | ||
| uint32 flags = B_NAVIGABLE | B_WILL_DRAW | B_FRAME_EVENTS); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.8 rule
| BMessageRunner* fTextModificationRunner; | ||
| BNumberFormat fNumberFormat; | ||
| uint32 fWhat; | ||
| bool fIsPercent; |
Check warning
Code scanning / Cppcheck (reported by Codacy)
class member 'SliderTextControl::fIsPercent' is never used.
| #define SLIDERTEXTCONTROL_H | ||
|
|
||
|
|
||
| #include <NumberFormat.h> |
Check warning
Code scanning / Cppcheck (reported by Codacy)
Include file: <NumberFormat.h> not found. Please note: Cppcheck does not need standard library headers to get proper results.
| thumb_style thumbType = B_BLOCK_THUMB, | ||
| uint32 flags = B_NAVIGABLE | B_WILL_DRAW | ||
| | B_FRAME_EVENTS); | ||
| bool isPercent = false, thumb_style thumbType = B_BLOCK_THUMB, |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.8 rule
| SliderTextControl(const char* name, const char* label, | ||
| BMessage* message, int32 minValue, | ||
| int32 maxValue, int32 stepValue = 1, | ||
| BMessage* message, int32 minValue, int32 maxValue, int32 stepValue = 1, |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.8 rule
|
Will have a look |
|
I managed to test and there are some issues, in fact. |
2 participants
WIP, more like stuck.