Skip to content

fix: raise active pane border z-index above xterm-screen to prevent bottom clipping#188

Merged
j4rviscmd merged 1 commit into
mainfrom
fix/fix-pane-border-zindex
Jun 3, 2026
Merged

fix: raise active pane border z-index above xterm-screen to prevent bottom clipping#188
j4rviscmd merged 1 commit into
mainfrom
fix/fix-pane-border-zindex

Conversation

@j4rviscmd
Copy link
Copy Markdown
Owner

Summary

The active pane border (::after pseudo-element) had z-index:6, which was below
.xterm-screen (z-index:31). This caused the terminal canvas to cover the bottom
border of the active pane in terminal-in-editor groups, while normal text editor
panes were unaffected.

Root Cause

.xterm-screen (from xterm.js) uses z-index:31 with position:relative. The active
pane border ::after was at z-index:6. Since both participate in the same stacking
context, the xterm canvas rendered on top of the border. The xterm element extends to
the very bottom of the editor group container, covering the bottom edge of the border.

The top border remained visible because xterm starts below the title bar area (xterm
top=64px vs group top=32px).

Fix

Raised z-index from 6 to 35:

  • Above all xterm layers (max z-index: 34 - terminal-drop-overlay)
  • Below hover/suggest widgets (z-index: 40+)
  • pointer-events: none ensures no interaction blocking

Files Changed

  • src/vs/workbench/browser/parts/editor/media/editorgroupview.css — editor group border
  • src/vs/workbench/browser/parts/media/paneCompositePart.css — sidebar/panel/auxiliarybar border

Test Plan

  • Terminal in Editor pane shows active border on all 4 sides
  • Normal text editor pane border unchanged
  • Hover popups render above the active border (not behind)

…ottom clipping

The active pane border (::after pseudo-element) had z-index:6, which was
below xterm-screen (z-index:31). This caused the terminal canvas to cover
the bottom border of the active pane in terminal-in-editor groups.

Raised to z-index:35, which is above all xterm layers (max 34) but below
hover/suggest widgets (z-index:40), preserving the fix from issue #181.
@j4rviscmd j4rviscmd added the bug Something isn't working label Jun 3, 2026
@j4rviscmd j4rviscmd merged commit 25032eb into main Jun 3, 2026
3 checks passed
@j4rviscmd j4rviscmd deleted the fix/fix-pane-border-zindex branch June 3, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant