fix: raise active pane border z-index above xterm-screen to prevent bottom clipping#188
Merged
Merged
Conversation
…ottom clipping The active pane border (::after pseudo-element) had z-index:6, which was below xterm-screen (z-index:31). This caused the terminal canvas to cover the bottom border of the active pane in terminal-in-editor groups. Raised to z-index:35, which is above all xterm layers (max 34) but below hover/suggest widgets (z-index:40), preserving the fix from issue #181.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The active pane border (
::afterpseudo-element) hadz-index:6, which was below.xterm-screen(z-index:31). This caused the terminal canvas to cover the bottomborder of the active pane in terminal-in-editor groups, while normal text editor
panes were unaffected.
Root Cause
.xterm-screen(from xterm.js) usesz-index:31withposition:relative. The activepane border
::afterwas atz-index:6. Since both participate in the same stackingcontext, the xterm canvas rendered on top of the border. The xterm element extends to
the very bottom of the editor group container, covering the bottom edge of the border.
The top border remained visible because xterm starts below the title bar area (xterm
top=64px vs group top=32px).
Fix
Raised
z-indexfrom6to35:pointer-events: noneensures no interaction blockingFiles Changed
src/vs/workbench/browser/parts/editor/media/editorgroupview.css— editor group bordersrc/vs/workbench/browser/parts/media/paneCompositePart.css— sidebar/panel/auxiliarybar borderTest Plan