Skip to content

Update multiset.py #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsevero wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update multiset.py #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions craystack/codecs/multiset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ def SamplingWithoutReplacement():
'''
Encodes and pops onto the ANS state using the empirical
distribution of symbols in the multiset.
Before an push, the symbol to be pushd is inserted into the multiset.
After a pop, the popd symbol is removed from the multiset. Therefore,
Before a push, the symbol to be pushed is inserted into the multiset.
After a pop, the poped symbol is removed from the multiset. Therefore,
Copy link
Owner

@j-towns j-towns Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 'popped'.

a pop performs sampling without replacement, while push inverts it.
The context is the multiset, i.e. *context = multiset
'''
Expand Down