Skip to content

Skip Pro feature messages in error capture #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TannerTorrey3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip Pro feature messages in error capture #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions hooks/ix-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,12 @@ function redact(s: string): string {
.replace(new RegExp(homedir(), "g"), "~");
}

/** Returns true if the message/stderr indicates a missing Pro feature (not an error). */
function isProFeatureMessage(message: string, stderr?: string): boolean {
const combined = `${message} ${stderr ?? ""}`;
return /requires Ix Pro|Install @ix\/pro|is a Ix\/pro feature|premium features/i.test(combined);
}

/** Capture and report an error asynchronously. Fire-and-forget. */
export function captureErrorAsync(
type: string,
Expand All @@ -138,6 +144,9 @@ export function captureErrorAsync(
command?: string,
stderr?: string,
): void {
// Skip expected Pro feature messages — these are not errors
if (isProFeatureMessage(message, stderr)) return;

// Fire in background — never block the hook
void (async () => {
try {
Expand Down