Skip to content

perf(proxy): optimize subdomain checking with incremental string building #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lamtrinhdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(proxy): optimize subdomain checking with incremental string building #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions proxy/filter/blocklists.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,20 @@ func (f *DomainFilter) filterBlocklists(reqCtx *requestcontext.RequestContext, d
if reqCtx.PrivacySettings[SUBDOMAINS_RULE] == RULE_BLOCK {
// iterate over all subdomains
parts := strings.Split(fqdn, ".")
for i := range len(parts) - 1 {
candidate := strings.Join(parts[i:], ".")
var candidate string
for i := len(parts) - 1; i >= 0; i-- {
// Build candidate incrementally by prepending current part
if i == len(parts)-1 {
candidate = parts[i]
} else {
candidate = parts[i] + "." + candidate
}

// Skip the full domain as it was already checked above
if i == 0 {
continue
}

// now, check if candidate domain is part of any blocklist entry
blocklisted, err = f.Cache.GetBlocklistEntry(context.Background(), blocklistId, candidate)
if err != nil {
Expand Down