Merged
Conversation
This was referenced Feb 19, 2026
ivogabe
requested changes
Feb 22, 2026
ivogabe
reviewed
Feb 26, 2026
ivogabe
reviewed
Feb 26, 2026
Owner
|
Thanks! I tuned the cond-to-select transformation slightly in 97014c7, and added a transformation that converts a select of a pair to a pair of selects (to enable further optimizations) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a
selectfunction that chooses a value based on a condition without branching.selectis similar tocondexcept it evaluates both branches and picks the result without branching.condwill automatically be simplified to aselectwhen both branches are considered cheap, based on a simple cost heuristic.(&&)and(||)are defined using if-then-else to enable short-circuiting. Using this new logic these can now get converted to aselect, which then will be turned into a logical and/or.The accelerate-llvm part: ivogabe/accelerate-llvm#11
How has this been tested?
-
Types of changes
Checklist