drop ivoa COORDS model dependency and replace with simpler definitions#13
Merged
Conversation
at the same time attempt to use the ADQL geom point type as the main implementation of position.
There was a problem hiding this comment.
Pull request overview
This PR updates the ProposalDM and ProposalManagement models to remove the dependency on the IVOA COORDS/STC coords model, replacing it with a simplified internal proposal:coords package and using ADQL geometry (adqlgeom:Point) as the primary representation for sky positions. It also bumps model/library versions and updates the build to use the ADQLGeomDM dependency and apply formatting to generated Java.
Changes:
- Replace COORDS/STC coordinate types with
proposal:coordsprimitives/dtypes (e.g.,mjd,CartesianPoint) andadqlgeom:Point-basedCelestialPosition. - Update example/test code to use the new position and polarization types (
CelestialPosition,Polarization,Mjd,SinglePointing) and newIvoidpackage. - Bump model versions to
0.7and adjust Gradle configuration/dependencies (ADQLGeomDM, Spotless, repository URL).
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/org/ivoa/dm/proposal/prop/NOTexample.java | Updates imports and replaces STC polarization enum usage with new proposal:coords.Polarization. |
| src/test/java/org/ivoa/dm/proposal/prop/LCOExample.java | Switches Ivoid import to org.ivoa.vodml.stdtypes.Ivoid. |
| src/test/java/org/ivoa/dm/proposal/prop/ExampleProposal.java | Migrates target coordinates to CelestialPosition with adqlgeom:Point and uses Mjd + new polarization enum. |
| src/test/java/org/ivoa/dm/proposal/prop/ExampleGenerator.java | Changes reference frame accessors from SpaceSys to String. |
| src/test/java/org/ivoa/dm/proposal/prop/EmerlinExampleTest.java | Updates field example from old STC point field to new SinglePointing/CelestialPosition using Point. |
| src/test/java/org/ivoa/dm/proposal/prop/EmerlinExample.java | Replaces STC polarization enum usage with proposal:coords.Polarization and updates Ivoid import. |
| src/test/java/org/ivoa/dm/proposal/prop/BaseGenerator.java | Updates getICRS/getICRF implementations to return String. |
| src/test/java/org/ivoa/dm/proposal/prop/BaseExample.java | Replaces STC SpaceSys objects with string reference frames; updates telescope location dtype field name to refpos. |
| src/test/java/org/ivoa/dm/proposal/prop/AbstractProposalTest.java | Adjusts coordinate frame assertions to the new CelestialTarget.coord.referenceFrame structure. |
| src/main/vodsl/proposaldm.vodsl | Bumps model version, switches import to ADQLGeomDM, adds proposal:coords package, introduces CelestialPosition, replaces/renames field types, and updates polarization/epoch modeling. |
| src/main/vodsl/proposalManagement.vodsl | Bumps model version, switches import to ADQLGeomDM, and updates telescope location type to proposal:coords.CartesianPoint. |
| src/main/vo-dml/proposaldm.vo-dml.xml | Regenerates VO-DML XML for model v0.7: new import, new coords package/types, updated target/field structures. |
| src/main/vo-dml/proposalManagement.vo-dml.xml | Regenerates VO-DML XML for model v0.7: import change and location type update. |
| settings.gradle.kts | Switches repository URL to the public repo endpoint. |
| mkdocs_template.yml | Sets docs_dir: docs/ for MkDocs configuration. |
| build.gradle.kts | Updates plugin/version/dependency, adds Spotless formatting for generated Java, and switches dependency to ADQLGeomDM. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pahjbo
added a commit
to orppst/pst-api-service
that referenced
this pull request
Mar 17, 2026
* simplifying of the coordsys just being string * actual source coordinates use a Point object from ADQLGeom see ivoa/ProposalDM#13 for all the changes to the model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
at the same time attempt to use the ADQL geom point type as the main implementation of position.