Add lager and mnesia as dependencies #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is easier then for tools generating releases to find all the dependencies.
Contributor
|
I think dobby_core_lib should include mnesia as a dependency but not start it. If dobby_core_lib starts mnesia then another application in the same node as dobby_core_lib cannot start. We need to find a way to "share" mnesia across applications. Maybe we can do something similar to erl_sshd? Have our own application that is a thin wrapper for mnesia to start it and install the tables needed by the other applications? We'll probably want to do something similar for cowboy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easier then for tools generating releases to find all the dependencies. So if there aren't any reasons against starting mnesia/lager the OTP-way merge this PR.