Skip to content

[Domains] Review domains #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siniakinaa wants to merge 5 commits into
base: dev
Choose a base branch
from
+11 −10
Open

[Domains] Review domains #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8437187
readymag.com: use URL directly as iframe
siniakinaa Jun 30, 2026
0251fba
accept text_html
siniakinaa Jun 30, 2026
6cc74e6
readymag.com: add more test URLs
siniakinaa Jun 30, 2026
5064dfc
fix typos
siniakinaa Jul 1, 2026
7968730
fix comment typos
siniakinaa Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@
var foundPluginsDict = {},
result = [];

// TODO: gether secondaryPlugins by dict, who uses mandatory params. Not full for-loop.
// TODO: gather secondaryPlugins by dict, who uses mandatory params. Not full for-loop.
for(var i = 0; i < mandatoryParams.length; i++) {
var pluginsIds = usedParamsDict[mandatoryParams[i]];
if (pluginsIds) {
Expand Down Expand Up @@ -1162,7 +1162,7 @@
}
}

// Check if some domain plugin returned some links (any data from `getLinks`, including `message`) withouth runtime or callback error.
// Check if some domain plugin returned some links (any data from `getLinks`, including `message`) without runtime or callback error.
// Also check if `getData` returned `message`.
// Also check if `getData` returned something, and no `getLink` method in plugin.
for(var i = 0; i < allData.length && !hasDomainData; i++) {
Expand Down Expand Up @@ -1273,7 +1273,7 @@
var link3 = link._uri?.replace(/\/+$/, '');

if (link1 === link2) {
link.error = "Canonical link is removed unlesss explicitely allowed";
link.error = "Canonical link is removed unless explicitly allowed";
} else if (link3 === link2) {
link.error = "Link redirected to the canonical";
}
Expand Down Expand Up @@ -2101,7 +2101,7 @@

if (hasRuns === 0) {

// If no available mathods found - check if some async methods still running.
// If no available methods found - check if some async methods still running.
for(var pluginId in usedMethods) {
var pluginMethods = usedMethods[pluginId];
for(var method in pluginMethods) {
Expand All @@ -2113,7 +2113,7 @@
}

if (getVarsInfo.pendingMethods) {
// Make last iteration. All `getVars` argumenets must be loaded at this moment.
// Make last iteration. All `getVars` arguments must be loaded at this moment.
getVarsInfo.pendingMethods = false;
getVarsInfo.lastIteration = true;
// Run last iteration.
Expand Down
11 changes: 6 additions & 5 deletions plugins/domains/readymag.com.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@ export default {

mixins: ["*"],

getLink: function(url, urlMatch) {
getLink: function(url) {

return {
html: '<a class="rm-mag-embed" href="' + url + '" data-uri="' + urlMatch[1] + '" data-width="responsive" target="_blank"></a>' +
'<script async src="https://readymag.com/specials/assets/embed_init.js" id="readymag-embed-init"></script>',
type: CONFIG.T.text_html,
rel: [CONFIG.R.app, CONFIG.R.ssl], // not inline due to ID in script tag
href: url.replace('readymag.com/', 'readymag.website/'),
accept: CONFIG.T.text_html,
rel: [CONFIG.R.app, CONFIG.R.ssl, CONFIG.R.iframely],
'aspect-ratio': 4/3
};

Expand All @@ -23,5 +22,7 @@ export default {
"https://readymag.com/rbphotography/57005/",
"https://readymag.website/rbphotography/57005/",
"https://readymag.website/rbphotography/57005/11/",
"https://readymag.com/designs/2818584/",
"https://readymag.com/designs/3290418/",
]
};
Loading