Skip to content

Request: make iframely_options optional #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nleush wants to merge 3 commits into
base: dev
Choose a base branch
from
+10 −7
Open

Request: make iframely_options optional #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5bdcbb
request: make `iframely_options` optional
nleush Jun 30, 2026
c9c8bd8
better error code extraction in `registerFetchError`
nleush Jul 3, 2026
4297d1f
remove complex logic
nleush Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,16 +1611,19 @@
if (!data.error && !data.status_code) {
console.warn('No error param in registerFetchError data', data);
} else if (data.error) {
// Convert runtime `error` to `error_code` and `error_message`.
if (typeof data.error === 'string') {
fetch_data.error_code = data.error
} else {
// Convert runtime `error` to `error_code` and `error_message`.
if (data.error.code) {
fetch_data.error_code = data.error.code;
}
if (data.error.message) {
fetch_data.error_message = data.error.message;
}
if (data.error.name) {
fetch_data.error_code = data.error.name;
}
if (!data.error.code && !data.error.message) {
fetch_data.error_message = '' + data.error;
}
Expand Down
12 changes: 6 additions & 6 deletions lib/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export default function(options, iframely_options, callback) {

var prefix = CONFIG.API_REQUEST_CACHE_PREFIX ? (CONFIG.API_REQUEST_CACHE_PREFIX + ':') : '';

var lang = iframely_options.getProviderOptions('locale');
var lang = iframely_options?.getProviderOptions('locale');
if (lang) {
prefix += lang + ':';
}
Expand All @@ -94,13 +94,13 @@ export default function(options, iframely_options, callback) {
}

if (error) {
iframely_options.registerFetchError({
iframely_options?.registerFetchError({
source: 'api',
url: options.uri,
error: error
});
} else if (result && result.status !== 200) {
iframely_options.registerFetchError({
iframely_options?.registerFetchError({
source: 'api',
url: options.uri,
status_code: result.status
Expand Down Expand Up @@ -153,7 +153,7 @@ export default function(options, iframely_options, callback) {
});
}

iframely_options.registerFetch({
iframely_options?.registerFetch({
source: 'api',
url: options.uri
});
Expand All @@ -171,7 +171,7 @@ export default function(options, iframely_options, callback) {
}

// Ignore proxy.cache_ttl, if options.cache_ttl === 0 - do not read from cache.
if (iframely_options.cache_ttl === 0) {
if (iframely_options?.cache_ttl === 0) {

if (useCacheOnly) {

Expand All @@ -197,7 +197,7 @@ export default function(options, iframely_options, callback) {
}
}

iframely_options.registerFetch({
iframely_options?.registerFetch({
source: 'cache',
url: options.uri
});
Expand Down
Loading