This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Arnavgoel branch#16
Open
arnav2 wants to merge 7 commits into
Open
Conversation
added 6 commits
March 13, 2022 22:01
| @@ -0,0 +1,9 @@ | |||
| import CircularProgress from '@mui/material/CircularProgress'; | |||
Contributor
There was a problem hiding this comment.
do we need a separate file for this ?
| import ReactLoader from './components/ReactLoader'; | ||
|
|
||
| const theme = createTheme(adaptV4Theme({ | ||
| const Login = lazy(() => import('./pages/Login')); |
Comment on lines
+15
to
+33
| const PeriodOptions = [ | ||
| { | ||
| label: "DAYS", | ||
| value: 1 | ||
| }, | ||
| { | ||
| label: "WEEKS", | ||
| value: 7 | ||
| }, | ||
| { | ||
| label: "MONTHS", | ||
| value: 30 | ||
| }, | ||
| { | ||
| label: "YEARS", | ||
| value: 365 | ||
| } | ||
| ]; | ||
|
|
Contributor
There was a problem hiding this comment.
Is this still valid ? We are not capturing this anymore
Comment on lines
+35
to
+50
| { | ||
| label: "$", | ||
| value: 1 | ||
| }, | ||
| { | ||
| label: "$$", | ||
| value: 2 | ||
| }, | ||
| { | ||
| label: "$$$", | ||
| value: 3 | ||
| }, | ||
| { | ||
| label: "$$$$", | ||
| value: 4 | ||
| } |
| @@ -0,0 +1,183 @@ | |||
| import React, {useState, useEffect} from "react"; | |||
| import { useForm } from "react-hook-form"; | |||
Contributor
There was a problem hiding this comment.
you would want to update this page
mohaimenhasan
suggested changes
May 6, 2022
Contributor
mohaimenhasan
left a comment
mohaimenhasan
left a comment
There was a problem hiding this comment.
overall LGTM but I don't want to merge the changes as of now. If you can kindly update the frontend files to the figma diagram that would be great
| @@ -0,0 +1,17 @@ | |||
| import React from "react"; | |||
Contributor
There was a problem hiding this comment.
LOL What is this file ?
| } | ||
|
|
||
| exports.createNewUser = async (req, res, next) => { | ||
| console.log(req.body.userName); |
| } | ||
| catch (error){ | ||
| responseVal = responseObj.constructResponseObject(error.message, error['statusCode'], null, error.name) | ||
| console.error('ERROR: ', responseVal); |
…improvements will be made in the later stage but for now this is good enough for MVP. As for the code base a lot of things are hardcoded but will be improved when we integrate with backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next work would include:
Testing
It was tested on the screen with varying lengths.
Known issue: The spacing in mainNav is a bit off right now and will be handled later