Skip to content

Fix "Map container not found" error#181

Merged
itskovacs merged 6 commits intoitskovacs:mainfrom
razvicm:fix-map-container
Feb 7, 2026
Merged

Fix "Map container not found" error#181
itskovacs merged 6 commits intoitskovacs:mainfrom
razvicm:fix-map-container

Conversation

@razvicm
Copy link
Copy Markdown
Contributor

@razvicm razvicm commented Feb 6, 2026

This tries to fix the issue reported here - #141, where on shared trips, a "Map container not found" error was displayed and the map was black. This PR adds a retry mechanism and provides the map with a default center value (not providing it causes some issues with the initialization)
image

@itskovacs please review it when the time allows as this is not really my tech stack and I've struggled a bit to get the project running. Maybe providing some instructions on how to set up the project for development would be beneficial.

Thanks again for the great work on this app!

@itskovacs
Copy link
Copy Markdown
Owner

Hi @razvicm 👋!

Thanks for taking the time to work on a fix! Even though I can't reproduce the issue, multiple people are seeing it, so this helps a lot 😅

Could you confirm that these changes fix the issue for you? I'm just going to add a counter to ensure it doesn't get stuck in a loop and set the default center to Paris 👍

@razvicm
Copy link
Copy Markdown
Contributor Author

razvicm commented Feb 7, 2026

Yes, it fixes the issue for me 😄 .
Sure, feel free to change/improve the logic.

@itskovacs itskovacs merged commit 58b3059 into itskovacs:main Feb 7, 2026
@itskovacs
Copy link
Copy Markdown
Owner

Thanks! 🤝

Please let me know if the issue happens again, I'll refactor the component to use viewChild() signals for a more robust solution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants