Closed
Conversation
Collaborator
|
Для экономии времени и удобства в это PR буду принимать и 3 и 4 лабы, просто потому что такая ситуация |
AvtoBBus
requested changes
Dec 17, 2025
Collaborator
AvtoBBus
left a comment
AvtoBBus
left a comment
There was a problem hiding this comment.
Отсутствует БЭМ в обоих лабах
Collaborator
There was a problem hiding this comment.
Вынесите стили в отдельный файл, также не вижу ссылок на остальные лабы
Comment on lines
+35
to
+38
| const num1 = document.getElementById("num1").value; | ||
| const num2 = document.getElementById("num2").value; | ||
| const operation = document.getElementById("operation").value; | ||
| const resultElement = document.getElementById("result"); |
Collaborator
There was a problem hiding this comment.
А если какой-то элемент не найден?
… вынесены в данную ветку, добавлен раздел "мои проекты" с ссылкой на все лабы, добавлена проверка элементов в калькуляторе
Collaborator
|
Приняты обе лабы |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.