[WIP] 5124: Cura login #375
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/5124-cura-login
branch
from
f1fcb10 to
880c108
Compare
# Conflicts: # composer.json # composer.lock
rimi-itk
force-pushed
the
feature/5124-cura-login
branch
from
880c108 to
37c677d
Compare
rimi-itk
force-pushed
the
feature/5124-cura-login
branch
from
41aa3a7 to
4f2f451
Compare
rimi-itk
force-pushed
the
feature/5124-cura-login
branch
from
4f2f451 to
7d8f987
Compare
rimi-itk
force-pushed
the
feature/5124-cura-login
branch
from
7d8f987 to
cdcf3ca
Compare
rimi-itk
force-pushed
the
feature/5124-cura-login
branch
from
b27986e to
b57261b
Compare
rimi-itk
force-pushed
the
feature/5124-cura-login
branch
from
71e1758 to
221fb5b
Compare
rimi-itk
force-pushed
the
feature/5124-cura-login
branch
from
620afcd to
479a495
Compare
| "payload" : { | ||
| "brugerId" : "az…", | ||
| "organisationsNavn" : "Digitalisering", | ||
| "brugerensNavn" : "…", |
| $query = [ | ||
| $this->settings->getUsernameClaim() => $username, | ||
| ]; | ||
| // $result = fetch($query) |
There was a problem hiding this comment.
Suggested change
| // $result = fetch($query) |
| // OS2Lloop fields | ||
| // 'os2loop_user_address' => '', | ||
| // 'os2loop_user_areas_of_expertise' => '', | ||
| // 'os2loop_user_biography' => '', |
There was a problem hiding this comment.
Suggested change
| // 'os2loop_user_biography' => '', |
...iles/custom/os2loop/modules/os2loop_cura_login/src/Controller/Os2loopCuraLoginController.php
Outdated
Show resolved
Hide resolved
sinejespersen
approved these changes
Sep 8, 2025
rimi-itk
force-pushed
the
feature/5124-cura-login
branch
from
df5b964 to
9010a2d
Compare
…troller/Os2loopCuraLoginController.php Co-authored-by: Sine Jespersen <sinejespersen@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/_#/tickets/showTicket/5124
Description
Tries to implement the stuff documented in a file on https://leantime.itkdev.dk/_?tab=files#/tickets/showTicket/5124.
Screenshot of the result
If your change affects the user interface you should include a screenshot of the result with the pull request.
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.