Introduce check for special characters#92
Open
jwasikpsnc wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
There is script's help page: |
Documentation build overview
48 files changed ·
|
olivhoenen
reviewed
Jun 22, 2026
| run: npm run lint | ||
|
|
||
| - name: Check for forbidden Unicode characters | ||
| run: bash backend/ci/forbidden_chars_check.sh frontend/ --ext .ts .tsx .js .jsx .json .html .css No newline at end of file |
Contributor
There was a problem hiding this comment.
Forgot to commit the script?
Contributor
There was a problem hiding this comment.
Not sure what the script is doing, but would this be captured by using RUFF preview rules like RUF001-3 (maybe in preview)
Collaborator
Author
There was a problem hiding this comment.
Yeah, the script was in my .gitignore....
I will check tomorrow if we can use RUF001 for /docs and /frontend (.rst, .js etc...).
For now, short answer i get from the google is "no"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution for #75
Added script to check frontend backend and docs for problematic unicode characters
Currently, the script fails with errors:
I made changes in
.github/workflows/frontend-linting.yml, so i request your review @mfiaudrin-epsyl@olivhoenen @SimonPinches @prasad-sawantdesai
Are you happy with the set of forbidden characters? Should we add more? Should we have less of them?