Skip to content

Feature/data operations #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
8 commits merged into from
Jun 5, 2026
Merged

Feature/data operations #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
47a1a0e
Distinction between visual changes and data manipulations
mfiaudrin-epsyl May 22, 2026
7d7faed
Allow the user to select interpolation method in data manipulation
mfiaudrin-epsyl May 22, 2026
4bc21bf
Merge branch 'develop' into feature/data_operations
mfiaudrin-epsyl Jun 3, 2026
07e29db
Finalize the selection of interpolation method after merge of interpo…
mfiaudrin-epsyl Jun 3, 2026
df69c4e
Keep axis range feature in visual customization
mfiaudrin-epsyl Jun 3, 2026
ba96088
Fix the dataGrid type for syntax
mfiaudrin-epsyl Jun 4, 2026
14011b9
Fix E2E access to visual customization
mfiaudrin-epsyl Jun 4, 2026
0ffc780
Fix props syntax in TreeLibrary component
mfiaudrin-epsyl Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/src/renderer/components/grid/GridLayoutPlot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
Axis,
Configuration,
Coordinates,
CustomizedGridType,
DataGridPlot,
DataPlotly,
GridLayoutPlotProps,
Expand Down Expand Up @@ -338,10 +339,10 @@ export const GridLayoutPlot = ({
* Customize plot
*/
const handleCustomization = useCallback(
(id: string) => {
(id: string, typeOfEdition: CustomizedGridType) => {
const updatedActive: Configuration = {
...active,
customizedGridLayout: id,
customizedGridLayout: { id: id, type: typeOfEdition },
};
updatedConfiguration(updatedActive);
},
Expand Down
33 changes: 26 additions & 7 deletions frontend/src/renderer/components/grid/HoverButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ import {
import {
IconBrandDatabricks,
IconCheck,
IconDatabaseEdit,
IconEdit,
IconPalette,
IconEyeEdit,
IconTrash,
} from '@tabler/icons-react';
import { useHover } from '@mantine/hooks';
import { Configuration, DataGridPlot } from '../../types';
import { Configuration, CustomizedGridType, DataGridPlot } from '../../types';
import {
applyRange,
containsFloat,
Expand All @@ -30,7 +31,7 @@ interface HoverButtonsProps {
shouldDisplayMetadata: boolean;
handleEditGrid: (id: string) => void;
handleInspectMetadata: (id: string) => void;
handleCustomization: (id: string) => void;
handleCustomization: (id: string, typeOfEdition: CustomizedGridType) => void;
handleDeleteGrid: (id: string) => void;
is3DView: boolean;
active3DTab: string;
Expand Down Expand Up @@ -275,15 +276,33 @@ export const HoverButtons = React.memo(

{data.coordinates.length && !shouldDisplayMetadata && (
// Show customization button only if plottable
<Tooltip label="Customize the grid">
<Tooltip label="Data manipulation">
<ActionIcon
variant="filled"
aria-label="Metadatas"
data-testid="customization-access-button"
onClick={() => handleCustomization(data.i)}
data-testid="data-customization-access-button"
onClick={() => handleCustomization(data.i, 'data')}
className={classes.actionButton}
>
<IconPalette
<IconDatabaseEdit
style={{ width: '70%', height: '70%' }}
stroke={1.5}
/>
</ActionIcon>
</Tooltip>
)}

{data.coordinates.length && !shouldDisplayMetadata && (
// Show customization button only if plottable
<Tooltip label="Visual customization">
<ActionIcon
variant="filled"
aria-label="Metadatas"
data-testid="visual-customization-access-button"
onClick={() => handleCustomization(data.i, 'visual')}
className={classes.actionButton}
>
<IconEyeEdit
style={{ width: '70%', height: '70%' }}
stroke={1.5}
/>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/renderer/components/tree/TreeLibrariesAccordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export const TreeLibrariesAccordion = ({
editedDataPlot={editedDataPlot}
checkedNodes={checkedNodes}
metadataGridLayout={stableMetadataGridLayout}
customizedGridLayout={stableCustomizedGridLayout}
customizedGridLayout={stableCustomizedGridLayout?.id}
previousEditedIdRef={previousEditedIdRef}
handleSelectChildren={handleSelectChildren}
getCheckedNodes={getNodesChecked}
Expand Down
1 change: 1 addition & 0 deletions frontend/src/renderer/layout/MainLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ export function MainLayout() {
synchronizedGrids: dataGrid.synchronizedGrids,
downsampled_method: dataGrid?.downsampled_method,
downsampled_size: dataGrid?.downsampled_size,
interpolated_method: dataGrid.interpolated_method,
xAxisData: dataGrid.xAxisData,
yAxisData: dataGrid.yAxisData,
y2AxisData: dataGrid?.y2AxisData,
Expand Down
Loading
Loading