Skip to content

Feature/data smoothing#72

Open
jwasikpsnc wants to merge 31 commits into
iterorganization:developfrom
jwasikpsnc:feature/data-smoothing
Open

Feature/data smoothing#72
jwasikpsnc wants to merge 31 commits into
iterorganization:developfrom
jwasikpsnc:feature/data-smoothing

Conversation

@jwasikpsnc

@jwasikpsnc jwasikpsnc commented May 20, 2026

Copy link
Copy Markdown
Collaborator
  • Updated /info/data_manipulation_methods/ workflow
  • Added Gaussian and Savitzky-Golay filters
  • Passing whole request structure to data_source layer instead of parameters extraction
  • Added smoothing tests
  • Updated docs

jwasikpsnc and others added 21 commits April 17, 2026 14:04
@jwasikpsnc
Add new request model. Rename response models.
d03ab1b
@jwasikpsnc
Data smoothing (WIP)
5a1db85
@jwasikpsnc
Update docs
a52b06a
@jwasikpsnc
Add interpolation without data creation. Update docstrings.
b1c3327
@jwasikpsnc
Fix interpolation bugs. Update tests.
279c759
@jwasikpsnc
Update interpolation docs.
d1a410d
@jwasikpsnc
Merge branch 'iterorganization:develop' into feature/data-smoothing-d…
66018e2 
…enoising
@jwasikpsnc
Merge data-smoothing-denoising into data-smoothing
7807d59
@jwasikpsnc
Merge data-smoothing-denoising into data-smoothing
8dfe769
@olivhoenen
Merge branch 'develop' into feature/interpolation-without-new-values
c2352ef
@jwasikpsnc
Add models for data manipulation
d0959d0
@jwasikpsnc
Add missing interface def. Delete old, unused argument.
9f0a1b8
@jwasikpsnc
Commit of shame - run linter
ad14563
@jwasikpsnc
Delete missed argument
782d1d8
@jwasikpsnc
Merge branch 'feature/interpolation-without-new-values' into feature/…
e4ddaf9 
…data-smoothing
@jwasikpsnc
Pass query object down to data source layer
ed502cb
@jwasikpsnc
Add data smoothing
4c30996
@jwasikpsnc
Merge remote-tracking branch 'refs/remotes/origin/develop' into featu…
4cab041 
…re/data-smoothing

# Conflicts:
#	backend/ibex/core/ibex_service.py
#	backend/ibex/data_source/data_source_interface.py
#	backend/ibex/data_source/imas_python_source.py
#	backend/ibex/data_source/imas_python_source_utils.py
#	backend/ibex/endpoints/data.py
#	backend/ibex/endpoints/info.py
#	backend/ibex/endpoints/schemas/info_schemas.py
@jwasikpsnc
Merge branch 'iterorganization:develop' into feature/data-smoothing
2e8bb56
@jwasikpsnc
Update data manipulation docs
53958af
@jwasikpsnc
Delete unused models
b9702f6
@mfiaudrin-epsyl mfiaudrin-epsyl mentioned this pull request May 22, 2026
Merged
@read-the-docs-community

read-the-docs-community Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 imas-ibex | 🛠️ Build #33110086 | 📁 Comparing 06e0c42 against latest (d786f12)

  🔍 Preview build  

130 files changed · + 80 added · ± 50 modified

+ Added

± Modified

olivhoenen
olivhoenen reviewed May 29, 2026
View reviewed changes
Comment thread backend/ibex/data_source/imas_python_source.py
@jwasikpsnc

jwasikpsnc commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@olivhoenen
Do you think it is good idea to create github action to find and report "problematic" unicode characters?
Already found more of them, namely:
u2018 - LEFT SINGLE QUOTATION MARK (‘)
u2019 - RIGHT SINGLE QUOTATION MARK (’)
They came to code when i was copying parameters description from scipy, e.g.:
:param cval: Value to fill past the edges of the input if mode is ‘constant’. Default is 0.0.
imas_python_source_utils.py:28
Fortunately they are located in docstring, but actively hunting for them would save us time for debugging in the future.

@olivhoenen

olivhoenen commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@olivhoenen Do you think it is good idea to create github action to find and report "problematic" unicode characters? Already found more of them, namely: u2018 - LEFT SINGLE QUOTATION MARK (‘) u2019 - RIGHT SINGLE QUOTATION MARK (’) They came to code when i was copying parameters description from scipy, e.g.: :param cval: Value to fill past the edges of the input if mode is ‘constant’. Default is 0.0. imas_python_source_utils.py:28 Fortunately they are located in docstring, but actively hunting for them would save us time for debugging in the future.

Yes, having the linter checking for these is indeed a good idea @jwasikpsnc

@jwasikpsnc

jwasikpsnc commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

Ok, will do it in separate branch

olivhoenen
olivhoenen reviewed Jun 1, 2026
View reviewed changes
Comment thread backend/ibex/endpoints/data.py
Comment thread backend/ibex/data_source/imas_python_source_utils.py Outdated
@jwasikpsnc jwasikpsnc marked this pull request as draft June 3, 2026 10:25
@jwasikpsnc

jwasikpsnc commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author
  • Allow to smooth 2D quantities when one of the coordinate is time

@jwasikpsnc jwasikpsnc marked this pull request as ready for review June 5, 2026 11:41
@jwasikpsnc

jwasikpsnc commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator Author

@olivhoenen
Now it is ready for further review

@olivhoenen

olivhoenen commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

e2e-tests fail, any idea @jwasikpsnc @mfiaudrin-epsyl ?

@mfiaudrin-epsyl

mfiaudrin-epsyl commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

e2e-tests fail, any idea @jwasikpsnc @mfiaudrin-epsyl ?

This looks to be the unstable E2E tests that we talk before. I rerun the failed job to ensure. If it's not that, I will do more investigations.

There is the error:
image

It happen sometimes and has to be fixed. Waiting for the fix, when we get StaleElementReferenceError we have to rerun failed jobs.

@jwasikpsnc jwasikpsnc mentioned this pull request Jun 18, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olivhoenen olivhoenen olivhoenen left review comments

@prasad-sawantdesai prasad-sawantdesai Awaiting requested review from prasad-sawantdesai prasad-sawantdesai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jwasikpsnc @olivhoenen @mfiaudrin-epsyl