Skip to content

fix: align UX flags with published modules#237

Merged
ootakazuhiko merged 1 commit into
mainfrom
codex/catalog-sprint-226-ux-236
Jul 12, 2026
Merged

fix: align UX flags with published modules#237
ootakazuhiko merged 1 commit into
mainfrom
codex/catalog-sprint-226-ux-236

Conversation

@ootakazuhiko

Copy link
Copy Markdown
Collaborator

Summary

Align UX metadata with the actual reader-facing modules audited for portfolio Sprint itdojp/it-engineer-knowledge-architecture#226.

  • readingGuide: false → true (dedicated public-top section)
  • checklistPack: true → false (no independent checklist pack)
  • figureIndex: true → false (no dedicated figure/table index)
  • legalNotice: false → true (public license section)
  • glossary: false → true (Appendix A, linked in navigation)
  • retain troubleshootingFlow=true for Appendix B
  • track missing Profile B checklistPack / figureIndex in portal [codex] Use PR list label on workflow top page #227

Verification

  • npm ci
  • npm run test:light
  • npm audit --audit-level=moderate (0 vulnerabilities)
  • Jekyll build
  • git diff --check

Existing npm allowScripts / Faraday warnings are tracked separately in #235.

Closes #236

Copilot AI review requested due to automatic review settings July 12, 2026 09:04
@ootakazuhiko

Copy link
Copy Markdown
Collaborator Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

本PRは、book-config.json の UX メタデータ(モジュール有効/無効フラグ)を、公開されている読者向けモジュール実体の監査結果に合わせて整合させる変更です(Issue #236 対応)。これにより、公開トップ/ナビゲーション上に存在する導線・セクションと、設定上の表示可否が一致することを意図しています。

Changes:

  • Profile B の readingGuidetrue に変更
  • Profile B の checklistPack / figureIndexfalse に変更
  • Profile B の legalNotice / glossarytrue に変更(troubleshootingFlow=true は維持)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 8955a41a76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ootakazuhiko ootakazuhiko merged commit 067f3d0 into main Jul 12, 2026
3 checks passed
@ootakazuhiko ootakazuhiko deleted the codex/catalog-sprint-226-ux-236 branch July 12, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P1][UX Metadata] reading/checklist/figure/legal/glossary flagsを公開実体へ合わせる

2 participants