Fix mobile sidebar closed state#232
Merged
ootakazuhiko merged 1 commit intoJun 7, 2026
Merged
Conversation
Collaborator
Author
|
@copilot review |
There was a problem hiding this comment.
Pull request overview
This PR fixes a mobile/tablet layout regression where the sidebar drawer could appear open (or layered incorrectly) due to later .book-sidebar desktop rules in main.css overriding the mobile rules imported earlier.
Changes:
- Make the mobile closed-state
transform: translateX(-100%)explicit and!importantto prevent later desktoptransform: translateX(0)from leaking into mobile/tablet widths. - Set the mobile sidebar
z-indexto999 !importantto ensure it stays above the overlay (950) while remaining below the fixed header (1000). - Add inline documentation explaining why
!importantis required given the current CSS import/order and desktop defaults.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot stopped work on behalf of
ootakazuhiko due to an error
June 7, 2026 06:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.csslater declares the desktop.book-sidebar { transform: translateX(0); }Note:
AGENTS.mdsaysdocs/assets/should generally not be hand-edited. For this Issue #168 public CSS defect, the configured Pages source ismain/docs, and nomobile-responsive.csssource template exists undertemplates/styles/; therefore this PR updates the published CSS directly and keeps the change to one file.Validation
npm cinpm run check:securitynpm run check:metadatanpm run lint:lightnpm run buildwith workspace-localBUNDLE_PATHgit diff --checkbooks=1 pages=10 ok=10 warn=0 fail=0sidebarZ=999,overlayZ=950; desktop unchangedPart of itdojp/it-engineer-knowledge-architecture#168.