Open
Conversation
The history field of Electron's webContents module is no longer present beyond Electron 10, so we have to stop using it in order to upgrade. webContents.history is ostensibly used to manage a subset of browsing history. My observation is that the global history (which includes itch:// URLs) is a superset of the webContents.history, so the theory is that we could rely entirely on the global history and back-forward navigation would work just as well. This commit introduces a new bug: after entering a URL such as `http://itch.io` into the address bar, the app will change the URL to `https://itch.io/` (note the change in protocol and the added trailing slash), and the history will end up with two entries when there should be only one. This means that going back from `https://itch.io/` will navigate to `http://itch.io` only to loop you back to `https://itch.io/`, rendering the back button useless in this particular scenario. I can't figure out how to fix this correctly, so to work around this in the common case, I'm changing the URL of the Explore sidebar entry so that at least the itch.io homepage won't have this problem. Closes itchio#2598
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to itchio/butler#242
This PR just adds a little icon, that the executable may not work on your system, if platform is not specified. This icon should only show up for executables, not for game assets, sound files etc.