Issue #13: [spring] Spring Boot integration — ItaraSpring fetch helper Implement ItaraSpring.get(Class) — a fetch helper that returns the wired proxy for a contract interface. The developer calls this in their @Configuration class to create their own bean explicitly.#49
Open
gyorgycsintalan wants to merge 2 commits into
Open
Issue #13: [spring] Spring Boot integration — ItaraSpring fetch helper Implement ItaraSpring.get(Class) — a fetch helper that returns the wired proxy for a contract interface. The developer calls this in their @Configuration class to create their own bean explicitly.#49gyorgycsintalan wants to merge 2 commits into
gyorgycsintalan wants to merge 2 commits into
Conversation
Implement ItaraSpring.get(Class) — a fetch helper that returns the wired proxy for a contract interface. The developer calls this in their @configuration class to create their own bean explicitly.
kissgabor94
reviewed
May 18, 2026
kissgabor94
requested changes
May 18, 2026
Collaborator
kissgabor94
left a comment
kissgabor94
left a comment
There was a problem hiding this comment.
Overall all good, two small comments that aren't functional issues.
| * <p>The returned instance is the Itara-wired proxy that was pre-registered | ||
| * by the agent during startup. | ||
| */ | ||
| public final class ItaraSpring { |
Collaborator
There was a problem hiding this comment.
I know the GitHub Issue required this class, but I'm wondering if we should just skip it. It suggests that this is spring specific, which isn't true, and if we do introduce spring specific support later on, the name will be confusing. Could you remove it and simply call the registry directly instead?
| log.info("=".repeat(50)); | ||
|
|
||
| // Small pause to let the agent's HTTP server start if needed | ||
| Thread.sleep(500); |
Collaborator
There was a problem hiding this comment.
I forgot to delete this in the other demo code, but it shouldn't be needed anymore, I think you can remove this sleep. When it's manually started, the user handles it, when docker-compose runs it, there is a dependency. It shouldn't be necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.