Skip to content

Clear unknowns in Helicopter#1710

Closed
Saritus wants to merge 11 commits intoisledecomp:masterfrom
Saritus:feature/clear-unknowns-in-helicopter
Closed

Clear unknowns in Helicopter#1710
Saritus wants to merge 11 commits intoisledecomp:masterfrom
Saritus:feature/clear-unknowns-in-helicopter

Conversation

@Saritus
Copy link
Copy Markdown
Contributor

@Saritus Saritus commented Jan 7, 2026

No description provided.

// 3: Landing
// 4: Good ending
// 5: Bad ending
MxU32 m_status; // 0x08
Copy link
Copy Markdown
Contributor Author

@Saritus Saritus Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: We could introduce preprocessor #defines to replace the magic integer values used for m_status

Like this:

// In LEGO1\lego\legoomni\include\helicopter.h
#define HELICOPTER_STATUS_LANDED 0
#define HELICOPTER_STATUS_TAKINGOFF 1

// In LEGO1\lego\legoomni\src\actors\helicopter.cpp
m_state->m_status = HELICOPTER_STATUS_LANDED;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, when I cleared unknowns and found those "states" I used an enum like in TowTrack. See also 05360b4.

@foxtacles foxtacles closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants