Skip to content

feat: enhance online migration with auto-creation and cleanup of publications and slots#7

Merged
isdaniel merged 1 commit into
mainfrom
feat/auto-creation-cleanup-pub-slot
May 8, 2026
Merged

feat: enhance online migration with auto-creation and cleanup of publications and slots#7
isdaniel merged 1 commit into
mainfrom
feat/auto-creation-cleanup-pub-slot

Conversation

@isdaniel
Copy link
Copy Markdown
Owner

@isdaniel isdaniel commented May 8, 2026

  • Added support for auto-creating publications during online migration if they do not exist.
  • Implemented cleanup of auto-created publications and replication slots after successful cutover.
  • Introduced CLI flags to control the auto-creation of publications and retention of replication slots.
  • Updated documentation to reflect changes in migration phases and resource management.
  • Added integration tests to verify the lifecycle of publications and slots during online migrations.
  • implement auto-creation and cleanup of publications and replication slots

…ications and slots

- Added support for auto-creating publications during online migration if they do not exist.
- Implemented cleanup of auto-created publications and replication slots after successful cutover.
- Introduced CLI flags to control the auto-creation of publications and retention of replication slots.
- Updated documentation to reflect changes in migration phases and resource management.
- Added integration tests to verify the lifecycle of publications and slots during online migrations.
- implement auto-creation and cleanup of publications and replication slots
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 89.45233% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.44%. Comparing base (442e188) to head (bded15f).

Files with missing lines Patch % Lines
pg_dbmigrator/src/orchestrator.rs 40.50% 47 Missing ⚠️
pg_dbmigrator/src/dump.rs 81.81% 4 Missing ⚠️
pg_dbmigrator/src/preflight.rs 99.60% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   90.22%   90.44%   +0.22%     
==========================================
  Files          16       16              
  Lines        5154     5633     +479     
==========================================
+ Hits         4650     5095     +445     
- Misses        504      538      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements automated lifecycle management for PostgreSQL replication resources, enabling the auto-creation of publications and the post-cutover cleanup of publications and replication slots. It introduces new CLI flags, --no-auto-create-publication and --keep-slot, and improves progress reporting by tracking table-level updates from pg_dump. The changes also include a major update to the development documentation and expanded integration testing. Feedback was provided to optimize the cleanup process by making the replication slot drop conditional on a successful wait for inactivity.

Comment thread pg_dbmigrator/src/orchestrator.rs
@isdaniel isdaniel merged commit 730da06 into main May 8, 2026
19 checks passed
@isdaniel isdaniel deleted the feat/auto-creation-cleanup-pub-slot branch May 8, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant