Fix numpy >= 2.0 TypeError in polyfit#150
Open
scottstanie wants to merge 1 commit intoisce-framework:mainfrom
Open
Fix numpy >= 2.0 TypeError in polyfit#150scottstanie wants to merge 1 commit intoisce-framework:mainfrom
scottstanie wants to merge 1 commit intoisce-framework:mainfrom
Conversation
`np.linalg.lstsq` returns `res` as a 1-element array. In numpy >= 2.0, `%f` string formatting no longer implicitly converts arrays to scalars, raising `TypeError: only 0-dimensional arrays can be converted to Python scalars`. Use `.item()` to explicitly extract the scalar value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: only 0-dimensional arrays can be converted to Python scalarswhen using s1reader with numpy >= 2.0np.linalg.lstsqreturnsresas a 1-element array. In numpy >= 2.0,%fstring formatting no longer implicitly converts arrays to scalars. Added.item()to explicitly extract the scalar value.See also Piyush's PR on isce3: isce-framework/isce3#226
Test plan
polyfitnow prints chi-squared correctly instead of raising TypeError