Remove the ionospheric phase mask from the wrapped interferogram#277
Merged
Conversation
added 30 commits
September 19, 2023 20:40
Contributor
Author
|
@oberonia78 and @seongsujeong can you take a look of this PR? I have tested, it looks good. Thanks |
seongsujeong
approved these changes
May 28, 2026
Contributor
seongsujeong
left a comment
seongsujeong
left a comment
There was a problem hiding this comment.
LGTM. Just few nit picks. Please make sure to address them before meeting.
| mask_description_suffix = ( | ||
| mask_description_no_iono | ||
| if ds_group_name == pixeloffsets_group_name | ||
| if ds_group_name in [wrapped_group_name,pixeloffsets_group_name] |
Contributor
There was a problem hiding this comment.
Suggested change
| if ds_group_name in [wrapped_group_name,pixeloffsets_group_name] | |
| if ds_group_name in [wrapped_group_name, pixeloffsets_group_name] |
| self.add_interferogramformation_to_algo_group() | ||
|
|
||
| def add_interferogram_to_swaths_group(self): | ||
| def add_interferogram_to_swaths_group(self,is_unwrapped=False): |
Contributor
There was a problem hiding this comment.
Suggested change
| def add_interferogram_to_swaths_group(self,is_unwrapped=False): | |
| def add_interferogram_to_swaths_group(self, is_unwrapped=False): |
| self.add_ionosphere_to_procinfo_params_group() | ||
|
|
||
| def add_interferogram_to_swaths_group(self): | ||
| def add_interferogram_to_swaths_group(self,is_unwrapped=False): |
Contributor
There was a problem hiding this comment.
Suggested change
| def add_interferogram_to_swaths_group(self,is_unwrapped=False): | |
| def add_interferogram_to_swaths_group(self, is_unwrapped=False): |
Tyler-g-hudson
pushed a commit
that referenced
this pull request
May 28, 2026
* sm r3.4 * change the SM commit id for R4.0.2 * remove the mask description for the wrapped ifgram * remove the tmp folder * fix minors --------- Co-authored-by: Xiaodong Huang <xhuang@nisar-adt-dev-3.jpl.nasa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to remove the ionospheric phase mask from the wrapped interferogram.