Reprojecting polar stereographic watermask to radargrid#271
Merged
seongsujeong merged 7 commits intoMay 28, 2026
Conversation
hfattahi
reviewed
May 21, 2026
Contributor
hfattahi
left a comment
hfattahi
left a comment
There was a problem hiding this comment.
We went half way reviewing. Few comments so far.
hfattahi
reviewed
May 27, 2026
oberonia78
reviewed
May 27, 2026
oberonia78
reviewed
May 27, 2026
oberonia78
reviewed
May 27, 2026
hfattahi
reviewed
May 27, 2026
Contributor
hfattahi
left a comment
hfattahi
left a comment
There was a problem hiding this comment.
Few more minor comments and clarifications.
Contributor
Author
|
@hfattahi @oberonia78 Would you mind another round of look? |
hfattahi
approved these changes
May 27, 2026
Contributor
hfattahi
left a comment
hfattahi
left a comment
There was a problem hiding this comment.
Thanks @seongsujeong for addressing my comments. LGTM!
oberonia78
reviewed
May 28, 2026
oberonia78
reviewed
May 28, 2026
Comment on lines
+889
to
+892
| phase_second = out_paths['RIFG'] | ||
| phase_second = out_paths['RUNW'] |
oberonia78
reviewed
May 28, 2026
Comment on lines
+892
to
+896
| diff_phase_output = pathlib.Path(diff_dir, 'RIFG.h5') | ||
| unwrap_needed = False | ||
| diff_phase_output = pathlib.Path(diff_dir, 'RUNW.h5') |
oberonia78
reviewed
May 28, 2026
Comment on lines
+932
to
+943
| if rerun_insar_pairs > 0: | ||
| dest_freq_path = f"{swath_path}/frequencyB" | ||
| dest_pol_path = f"{dest_freq_path}/interferogram/{pol_b}" | ||
| rifg_path_freq = f"{dest_pol_path}/wrappedInterferogram" | ||
|
|
||
| dest_freq_path = f"{swath_path}/frequencyB" | ||
| dest_pol_path = f"{dest_freq_path}/interferogram/{pol_b}" | ||
| rifg_path_freq = f"{dest_pol_path}/wrappedInterferogram" | ||
| second_data_path.append(rifg_path_freq) | ||
| else: | ||
| dest_freq_path = f"{runw_swath_path}/frequencyB" | ||
| dest_pol_path = f"{dest_freq_path}/interferogram/{pol_b}" | ||
| runw_path_b_freq = f"{dest_pol_path}/unwrappedPhase" | ||
|
|
||
| second_data_path.append(rifg_path_freq) | ||
| second_data_path.append(runw_path_b_freq) |
oberonia78
reviewed
May 28, 2026
Comment on lines
+954
to
+965
| unwrap.run(iono_insar_cfg, out_paths['RIFG'], out_paths['RUNW']) | ||
|
|
||
| if unwrap_needed: | ||
| unwrap.run(iono_insar_cfg, out_paths['RIFG'], out_paths['RUNW']) |
Tyler-g-hudson
pushed a commit
that referenced
this pull request
May 28, 2026
* fix a bug in projecing water to cryosphere region * fix issue in unitttest * extend the input raster's EPSG beyond 4326 * Apply suggestion from code review * Apply suggestion from PR review * apply suggestion from PR review --------- Co-authored-by: Jungkyo Jung <56169931+oberonia78@users.noreply.github.com> Co-authored-by: Jungkyo Jung <jungkyoj@nisar-adt-dev-5.jpl.nasa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is built upon #253 by @oberonia78 that addresses several issues in watermask reprojection. One of the issues was the necessity to reproject the watermask in polar stereographic (or any projection except for WGS84) to the radargrid.
This PR addresses the issue by transforming the longitude / latitude loaded from
x.rdrandy.rdrin scratch directory to polar stereographic.Below is the input watermask in EPSG 3413 (top), and reprojected to radargrid (bottom). of the test data.
For the record, below is the granule names of reference and secondary
NISAR_L1_PR_RSLC_012_015_A_037_7700_SHNA_A_20260203T054101_20260203T054138_X05012_N_P_J_001NISAR_L1_PR_RSLC_013_015_A_037_7700_SHNA_A_20260215T054102_20260215T054139_X05012_N_P_J_001