Fix Chirp Correlator and Cal Type in Raw, NET, RSLC EAP and NEB#231
Open
rad-eng-59 wants to merge 28 commits intoisce-framework:developfrom
Open
Fix Chirp Correlator and Cal Type in Raw, NET, RSLC EAP and NEB#231rad-eng-59 wants to merge 28 commits intoisce-framework:developfrom
rad-eng-59 wants to merge 28 commits intoisce-framework:developfrom
Conversation
Contributor
Author
|
@Tyler-g-hudson , FYI your valuable comments from #192 are already incorporated in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the merged combination of the two exiting PR #192 and PR #211 plus some minor improvements.
The main reason for the merge is that these two older PRs are fixing mainly the the same underlying issue with telemetry but for two different applications. Besides, this avoids merging conflict in future while placing the respective common helper functions under appropriate namespaces at once. Thus, once this PR is reviewed and ready to merge, those two older PRs can be safely removed.
Here is the summary of key updates: